feat(scripts): add MACI key generation script #1869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add generateMaciKeys.js script
- Update package.json with new script command
- Update .gitignore to exclude maci-keys directory
programmerraja
requested review from
ctrlc03,
kittybest,
0xmad and
crisgarner
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
0xmad
requested changes
Oct 25, 2024
scripts/generateMaciKeys.js
Outdated
scripts/generateMaciKeys.js
Outdated
| publicKey: pubKey.toString(), | ||
| }; | ||
|
|
||
| const outputDir = path.join(__dirname, "..", "maci-keys"); |
There was a problem hiding this comment.
Suggested change
| const outputDir = path.join(__dirname, "..", "maci-keys"); | |
| const outputDir = path.resolve(__dirname, "..", "maci-keys"); |
scripts/generateMaciKeys.js
Outdated
| fs.mkdirSync(outputDir, { recursive: true }); | ||
| } | ||
|
|
||
| const outputFile = path.join(outputDir, "maci-keys.json"); |
There was a problem hiding this comment.
Suggested change
| const outputFile = path.join(outputDir, "maci-keys.json"); | |
| const outputFile = path.resolve(outputDir, "maci-keys.json"); |
scripts/generateMaciKeys.js
Outdated
Comment on lines
14
to
16
| if (!fs.existsSync(outputDir)) { | ||
| fs.mkdirSync(outputDir, { recursive: true }); | ||
| } |
scripts/generateMaciKeys.js
Outdated
| } | ||
|
|
||
| const outputFile = path.join(outputDir, "maci-keys.json"); | ||
| fs.writeFileSync(outputFile, JSON.stringify(keys, null, 2)); |
|
@0xmad can you check and let me know anything else i want to change |
0xmad
reviewed
Oct 28, 2024
scripts/generateMaciKeys.ts
Outdated
Comment on lines
3
to
4
| import { promises as fs } from "fs"; | ||
| import * as path from "path"; |
There was a problem hiding this comment.
Suggested change
| import { promises as fs } from "fs"; | |
| import * as path from "path"; | |
| import fs from "fs"; | |
| import path from "path"; |
scripts/generateMaciKeys.ts
Outdated
|
|
||
| const outputDir = path.resolve(__dirname, "..", "maci-keys"); | ||
| try { | ||
| await fs.access(outputDir); |
There was a problem hiding this comment.
Suggested change
| await fs.access(outputDir); | |
| await fs.promises.access(outputDir); |
There was a problem hiding this comment.
And the same change for other fs calls
There was a problem hiding this comment.
@0xmad done can you check
ctrlc03
reviewed
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add MACI key generation script
- Add generateMaciKeys.js script
- Update package.json with new script command
- Update .gitignore to exclude maci-keys directory
feat for #1861
Additional Notes
Related issue(s)
Confirmation